Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#835 Feature/allow class directly at node flow #890

Merged
merged 10 commits into from
Jul 25, 2019
Merged

#835 Feature/allow class directly at node flow #890

merged 10 commits into from
Jul 25, 2019

Conversation

ashishjain0512
Copy link
Collaborator

#835

This introduces a feature to allow attaching the style class directly at vertex/node declaration in a flow chart.

@ashishjain0512 ashishjain0512 requested a review from knsv July 23, 2019 20:07
@coveralls
Copy link

Pull Request Test Coverage Report for Build 862

  • 38 of 140 (27.14%) changed or added relevant lines in 2 files are covered.
  • 159 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-5.7%) to 47.552%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/diagrams/sequence/parser/sequenceDiagram.js 14 18 77.78%
src/diagrams/flowchart/parser/flow.js 24 122 19.67%
Files with Coverage Reduction New Missed Lines %
src/diagrams/sequence/parser/sequenceDiagram.js 1 67.34%
src/diagrams/flowchart/flowDb.js 39 35.03%
src/diagrams/flowchart/parser/flow.js 119 33.05%
Totals Coverage Status
Change from base Build 857: -5.7%
Covered Lines: 2176
Relevant Lines: 4462
💛 - Coveralls

@knsv knsv merged commit 1ac126f into master Jul 25, 2019
@knsv knsv deleted the feature/allow-class-directly-at-node-flow branch September 18, 2019 18:28
This was referenced Jan 25, 2024
Open
Open
@X-oss-byte X-oss-byte mentioned this pull request Mar 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knsv knsv Awaiting requested review from knsv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashishjain0512 @coveralls @knsv